| From: | zengman <zengman(at)halodbtech(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Inline non-SQL SRFs using SupportRequestSimplify |
| Date: | 2025-12-21 02:48:07 |
| Message-ID: | tencent_2DD7C01758D855FF70B3E6DD@qq.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Well, from my perspective, the test logic for this feature seems a bit odd:
even if you directly modify the function body to return NULL; or return 1/0;,
none of this execution logic takes effect at all—it serves no purpose whatsoever as long as inlining succeeds.
This could be unfriendly to developers who are new to this feature,
so I added a test for this scenario to verify that our logic falls back to the function body when inlining fails.
This may just be my personal opinion, though; if you think everything is fine, we can leave it as it is.
--
Regards,
Man Zeng
www.openhalo.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2025-12-21 04:37:18 | Re: Implement waiting for wal lsn replay: reloaded |
| Previous Message | Bruce Momjian | 2025-12-21 02:08:47 | Re: should we have a fast-path planning for OLTP starjoins? |