Re: typedef indentation in pg_shmem.h

From: zengman <zengman(at)halodbtech(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: typedef indentation in pg_shmem.h
Date: 2026-01-13 03:59:32
Message-ID: tencent_28085CE854A5CA8E19E1C26F@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> The typedefs PGShmemType and HugePagesType are not indented properly.
> That's because those entries are missing from typedefs list. Is that
> intentional? Here's tiny patch fixing the indentation and typedefs
> list.

Hi all,

I just came across this email and wanted to chime in: it appears that a number of types in the kernel have in fact been omitted from the typedefs.list, and it’s likely they were overlooked. For example:
```
BTParallelScanDescData
AfterTriggerEventDataNoOids
AfterTriggerEventDataOneCtid
AfterTriggerEventDataZeroCtids
PartitionDispatchData
MergeJoinClauseData
BufferAccessStrategyData
lwlock_stats_key
lwlock_stats
SerialControlData
AllocBlockData
```
I’m wondering if it’s worth addressing these.

--
Regards,
Man Zeng
www.openhalo.org

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-01-13 04:02:54 Re: ALTER TABLE: warn when actions do not recurse to partitions
Previous Message David G. Johnston 2026-01-13 03:42:08 Re: ALTER TABLE: warn when actions do not recurse to partitions