Re: tuple radix sort

From: zengman <zengman(at)halodbtech(dot)com>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tuple radix sort
Date: 2026-02-11 10:25:07
Message-ID: tencent_1565D02652E0DC26675AABE2@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>I did some more self-review after a couple weeks and made some more
>minor cosmetic adjustments for v7. I will commit 0001 and 0002 in a
>few days unless there are objections.

Hi John,

I'm wondering if we should replace `state->memtuples` with `data` in the `sort_byvalue_datum()` function here.
```
if (nulls_first)
{
null_start = state->memtuples;
null_count = d1;
not_null_start = state->memtuples + d1;
not_null_count = d2;
}
else
{
not_null_start = state->memtuples;
not_null_count = d1;
null_start = state->memtuples + d1;
null_count = d2;
}
```
If my understanding is wrong, please ignore this.

--
regards,
Man Zeng

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message zengman 2026-02-11 10:28:44 Re:Miscellaneous message fixes
Previous Message Amit Kapila 2026-02-11 10:10:50 Re: [Patch] add new parameter to pg_replication_origin_session_setup