Re: [PATCH] aio: Refactor to deduplicate shared and local completion callbacks

From: zengman <zengman(at)halodbtech(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] aio: Refactor to deduplicate shared and local completion callbacks
Date: 2026-01-02 14:46:24
Message-ID: tencent_118EBB44338AE1F742F8ADC4@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> It doesn't really seem to improve things sufficiently for my taste. If you
> don't remove comments that are actually important, like "Note that we don't
> save the result", the code doesn't even get shorter. And it's not like the
> function afterwards is more generic, since it encodes all the knowledge about
> the different callback kinds.

Thanks for the feedback. I’ll think of a better approach.
Thanks for the guidance.

--
Regards,
Man Zeng
www.openhalo.org

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2026-01-02 15:14:54 Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore
Previous Message Srirama Kucherlapati 2026-01-02 14:43:00 RE: AIX support