[PATCH] backup: Fix trivial typo and error message issues

From: zengman <zengman(at)halodbtech(dot)com>
To: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: [PATCH] backup: Fix trivial typo and error message issues
Date: 2026-01-15 13:02:42
Message-ID: tencent_0F2949C4594556F672CF4658@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

I noticed two trivial issues in backup-related code:
1. backup_manifest.c: The timeline mismatch error message uses `starttli` instead of `endtli`.
2. basebackup_copy.c: There is a spelling error (sine → since) in the comment above the `PROGRESS_REPORT_BYTE_INTERVAL` macro.

```
--- a/src/backend/backup/backup_manifest.c
+++ b/src/backend/backup/backup_manifest.c
@@ -253,7 +253,7 @@ AddWALInfoToBackupManifest(backup_manifest_info *manifest, XLogRecPtr startptr,
if (first_wal_range && endtli != entry->tli)
ereport(ERROR,
errmsg("expected end timeline %u but found timeline %u",
- starttli, entry->tli));
+ endtli, entry->tli));
```

```
- * So we only check it after the number of bytes sine the last check reaches
+ * So we only check it after the number of bytes since the last check reaches
```

--
Regards,
Man Zeng
www.openhalo.org

Attachment Content-Type Size
0001-Update-error-message-in-AddWALInfoToBackupManifest-f.patch application/octet-stream 1.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2026-01-15 13:15:30 Re: Proposal: SELECT * EXCLUDE (...) command
Previous Message Jakub Wartak 2026-01-15 12:28:30 Re: pg_plan_advice