| From: | 慈超云 <cichaoyun(at)halodbtech(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] Remove unused is_error parameter from TeardownHistoricSnapshot() |
| Date: | 2026-03-06 07:34:16 |
| Message-ID: | tencent_0602D4A244D19D1513EBB209@qq.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
I found that the is_error parameter of the TeardownHistoricSnapshot() function is not actually used anywhere in the code.
This parameter was introduced in commit
b89e151054a05f0f6d356ca52e3b725dd0505e53 as part of the logical decoding feature, but has never been used. The function just sets two global pointers to NULL regardless of the parameter value.
So I' ve submitted a patch to remove this unused parameter.
Please see the attached patch for details.
Best regards,
Chaoyun
杭州易景数通科技有限公司
慈超云
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Subject-PATCH-Remove-unused-parameter-from-Teardo.patch | application/octet-stream | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rafia Sabih | 2026-03-06 07:37:01 | Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement |
| Previous Message | Chao Li | 2026-03-06 07:31:36 | Re: Add pg_stat_recovery system view |