| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remove pg_restrict workaround |
| Date: | 2026-01-03 16:47:09 |
| Message-ID: | t7c3shj2mdo7wtwmxgt32rv66qcypnp5blys5skqlem7j5ua5h@kunmzc77aebb |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2026-01-03 00:23:37 +0100, Jelte Fennema-Nio wrote:
> On Wed, 29 Oct 2025 at 08:04, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> > Committed with a backward compatibility define.
>
> I'm working on adding a C++ extension module to my copyObject
> patchset[1]. But turns out that this change has completely broken
> compiling C++ extensions on MSVC. This is happening due to
> __declspec(restrict) being replaced by __declspec(__restrict), which
> the original comments also mentioned as the reason for having our own
> flavor. This replacement then makes the core of a corecrt_malloc.h
> MSVC header invalid[2].
>
> So I think we should revert this patch.
+1
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-01-03 17:05:19 | Re: some Page/PageData const stuff |
| Previous Message | Xuneng Zhou | 2026-01-03 16:10:44 | Re: Implement waiting for wal lsn replay: reloaded |