Re: pg_*_advice: tsv load failure, etc.

From: Dongpo Liu <poe(dot)liu(at)pm(dot)me>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_*_advice: tsv load failure, etc.
Date: 2026-10-23 15:54:52
Message-ID: sk3WwFMHQN89QQyWkzBse7YqkPi-IIg0QJpaIgGqgbO-SJjRxWbeONBeWKDa5IEUMHbEwOx8Z-1yuZMhU4l_vsLgRZPEWSV6eFu_5zGy238=@pm.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Friday, October 23rd, 2026 at 5:41 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> #19 might be a real bug, but needs validation, and can't be easily
> validated with in-core code.

Hi Robert,

I am still getting used to how discussions are organized on this list. I
posted a reproducer and patch in a separate thread [1]. Since the
related discussion is continuing here, I thought it might be helpful to
add a link here as well.

I confirmed #19 with a small test-only CustomScan provider. When a
CustomScan replaces a join within a larger join, EXPLAIN (PLAN_ADVICE)
can fail with "plan node has no RTIs". The patch makes pgpa_relids()
return CustomScan.custom_relids.

When you have a chance, I would appreciate your thoughts on the patch. I
would also welcome your advice on adding a join case to test_extensible
for regression coverage.

[1] https://www.postgresql.org/message-id/sSMpyoJ12CV5Y3uS-T_8Z3M1xsJBELBd-Vh5DmlC9_jy9TOqMuWzr8-TuXrBpL8AlPlyEFkyQ4wX5guJCyVizY-R2UET0DpIEeA1aSsUjk4%3D%40pm.me

Best regards,
Dongpo Liu

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Burd 2026-10-23 16:05:17 Re: Expanding HOT updates for expression and partial indexes
Previous Message Heikki Linnakangas 2026-10-23 15:47:24 Re: Return pg_control from pg_backup_stop().