I/O worker and ConfigReload

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Andres Freund <andres(at)anarazel(dot)de>
Subject: I/O worker and ConfigReload
Date: 2025-05-24 13:56:31
Message-ID: sh5uqe4a4aqo5zkkpfy5fobe2rg2zzouctdjz7kou4t74c66ql@yzpkxb7pgoxf
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I've been rebasing the patch for online resizing of shared memory, and
noticed something strange about IoWorkerMain: although it sets the
handler SignalHandlerForConfigReload, it doesn't look like it acts upon
ConfigReloadPending. From what I see it happens because it only does
CHECK_FOR_INTERRUPTS in the main worker loop, which doesn't handle
ConfigReloadPending.

In the context of shared memory resizing patch it means I/O workers are
not receiving the new value of NBuffers and crash. Adding something like
pgaio_worker_process_interrupts to deal with ConfigReloadPending at the
beginning of the main worker loop seems to solve the issue. But I
haven't found any discussion about config reload in I/O workers, was
this omission intentional?

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2025-05-24 14:00:22 Re: pg18: Virtual generated columns are not (yet) safe when superuser selects from them
Previous Message Hannu Krosing 2025-05-24 13:47:14 [PATCH] Extending FK check skipping on replicas to ADD FK and TRUNCATE