Re: Annoying warning in SerializeClientConnectionInfo

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andy Fan <zhihuifan1213(at)163(dot)com>
Subject: Re: Annoying warning in SerializeClientConnectionInfo
Date: 2025-08-13 14:25:25
Message-ID: ru22zkposrpvopmgkaejafl2izv4jzc7jr6f6hh3efrnucivkp@idaumq7jjhkm
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-08-13 12:54:27 +0900, Michael Paquier wrote:
> > I think the PG_USED_FOR_ASSERTS_ONLY fix is preferable for backport,
> > so I don't want to get in the way of that approach.
>
> The attached has been working for me. Thoughts?

I think we shouldn't add the attribute to the declaration, just to the
function. The caller doesn't need to know that it's unused, it's purely a
question of the specific implementation that the attribute is unused.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-08-13 14:39:50 Re: cfbot mistakenly reports that a rebase is needed
Previous Message Andres Freund 2025-08-13 14:24:07 Re: meson: Add _static and _shared suffixes to the library names