Re: make -C src/test/isolation failure in index-killtuples due to btree_gist

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
Date: 2025-10-30 15:24:55
Message-ID: rej3pew44i4bgpyk3hl42ftjo7vndesbppjbklqiijo6k4gb2b@cc5vxjt6nvio
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-10-28 16:55:49 +0900, Michael Paquier wrote:
> On Fri, Aug 22, 2025 at 07:46:43PM -0400, Andres Freund wrote:
> > That would be the easiest fix - but I'm starting to wonder if it shouldn't
> > just be its own test module, as annoying as the boilerplate for that is.
> >
> > While the test improved code coverage for the various indexes noticeably, I
> > did subsequently realize that the new test doesn't end up testing the recovery
> > path :(. Better than nothing, but having any coverage of those paths might be
> > worth the boilerplate and the runtime overhead of a test module :/
>
> Adding just an EXTRA_INSTALL to isolation's Makefile would not work,
> no?

How precisely to get the contrib module installed seems like a boring
detail. It's not hard to do that, if we decide that that's the way to go, even
without EXTRA_INSTALL.

> How about a new test/modules/gist/ then?

Well, it tests multiple index types, not just gist. I guess
test/modules/indexes/ or so should work? Not sure about plural or not.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2025-10-30 15:30:22 Re: GNU/Hurd portability patches
Previous Message Tom Lane 2025-10-30 15:22:08 Re: Use BumpContext contexts for TupleHashTables' tablecxt