Re: Remove freelist reference in buf_init.c

From: Andres Freund <andres(at)anarazel(dot)de>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove freelist reference in buf_init.c
Date: 2026-02-03 15:14:11
Message-ID: qzat6eywgt6gxtprzyozdf36xgautuw5admtpjjjz2btx42ltr@4yagnl4rkwpy
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2026-02-03 10:48:30 +0530, Ashutosh Bapat wrote:
> We have gotten rid of freelist in buffer manager, but buf_init.c still
> has a reference to it in a comment. Patch to remove the reference.
>
> Other references to freelist refer to freelist.c which is still a
> valid filename reference. Hence I didn't touch it.

I'm not sure this enough of an improvement to really be worth it. I think we
probably ought to rename freelist.c to buf_replacement.c or such. Which of
course will require more comment changes.

Even if we don't, I think that the entire comment in buf_init.c is misplaced
and bound to not be updated. Nobody is looking for it there, both when trying
to learn about the code and when changing the code.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Aditya Kamath 2026-02-03 15:23:54 RE: AIX support
Previous Message Florents Tselai 2026-02-03 15:07:18 Re: Add LIMIT option to COPY FROM