From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Subject: | Re: [PATCH] Remove unused #include's in src/backend/commands/* |
Date: | 2025-10-09 13:18:06 |
Message-ID: | qky3etnj64r7zugj5wpifetfsaqprw4myy3z6eqdcmnrqxsrjp@oxajbtdamq4t |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2025-10-09 16:08:38 +0300, Aleksander Alekseev wrote:
> > > OK, I tried include-what-you-use with a little post-processing script
> > > and the scope of work seems reasonable. I will submit the updated
> > > patch shortly.
> >
> > Here is the updated patch v3.
>
> Apparently touching collationcmds.c, restricted_token.c and
> fe-auth-oauth.c was a mistake. Here is the corrected patch v4.
Clearly this approach is not bulletproof enough to actually yield something
reliable enough to actually be applied.
> From 81089fdf47561a4a68f80ebe238e8d5a452f7c0b Mon Sep 17 00:00:00 2001
> From: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
> Date: Wed, 8 Oct 2025 15:58:38 +0300
> Subject: [PATCH v4] Remove unused #include's
>
> Author: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
> Reviewed-by: Nathan Bossart <nathandbossart(at)gmail(dot)com>
> Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
I've not reviewed this.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksander Alekseev | 2025-10-09 13:26:20 | Re: [PATCH] Remove unused #include's in src/backend/commands/* |
Previous Message | Greg Burd | 2025-10-09 13:11:43 | Re: [PATCH] Add tests for Bitmapset |