| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomasz Szypowski <tomasz(dot)szypowski(at)gmail(dot)com> |
| Subject: | Re: pg_upgrade version checking questions |
| Date: | 2019-03-25 23:12:12 |
| Message-ID: | pC-NMmh4vQLQP76YTwY4AuoD4OdNw9egikekyQpXFpgqmTlGjIZXOTd2W5RDZPpRski5N3ADRrLYgLk6QUuvmuT5fWC9acPAYyDU1AVxJcU=@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, March 19, 2019 12:35 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I noticed a few things that seem a bit fishy about pg_upgrade.
Attached are three patches which takes a stab at the issues raised here (and
the discussion in this thread):
0001 - Enforces the version check to the full version including the minor
0002 - Tests for all the binaries that pg_upgrade executes
0003 - Make -B default to CWD and remove the exec_path check
Defaulting to CWD for the new bindir has the side effect that the default
sockdir is in the bin/ directory which may be less optimal.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Check-all-used-executables.patch | application/octet-stream | 876 bytes |
| 0003-Default-new-bindir-to-CWD.patch | application/octet-stream | 3.9 KB |
| 0001-Only-allow-upgrades-by-the-same-exact-version-new-bi.patch | application/octet-stream | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-03-25 23:29:49 | Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath |
| Previous Message | Tom Lane | 2019-03-25 22:56:38 | Re: Fix XML handling with DOCTYPE |