| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Subject: | Re: Bug in pg_stat_statements |
| Date: | 2025-10-26 11:16:14 |
| Message-ID: | ny3mdn3lmq47osrwqeadkeuncuotyvszizt2mmv63iagypp7xd@3jjjxkt4vwrr |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Fri, Oct 24, 2025 at 07:04:59PM -0500, Sami Imseih wrote:
> v4 corrects some code comments.
The fix in the first patch looks good, thanks. Not so sure about the
refactoring in the second patch -- generate_normalized_query is being
used only in one place, in pg_stat_statements, moving it out somewhere
else without having other clients seems to be questionable to me.
P.S. Adding Álvaro as a commiter of the affected feature, maybe he will
help us to apply the fix.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-10-26 15:16:07 | Re: PG18 GIN parallel index build crash - invalid memory alloc request size |
| Previous Message | Filip Janus | 2025-10-26 10:20:53 | Re: Channel binding for post-quantum cryptography |