| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alexander Law <exclusion(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Typos in the code and README |
| Date: | 2026-01-06 13:43:59 |
| Message-ID: | njw4dabygfm4q2vpa4snu5xhpozjcn5p4pz4cwsntcvq3gr5wp@jql4yxgghscw |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2026-01-06 12:27:29 +0900, Michael Paquier wrote:
> On Mon, Jan 05, 2026 at 11:00:00PM +0400, Alexander Law wrote:
> > I thought that the initial spelling was meant to reference bufHdr variable
> > as if it was declared locally as we can see this name in other functions in
> > bufmgr.c (at 5d508736).
>
> Yeah, I was under the same impression as yours. The older pattern
> could not be found in the tree, the new one is all spread around.
Sure, but that function doesn't use bufHdr, making the new phrasing just as
confusing as the old one.
Greetings,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dharin Shah | 2026-01-06 13:46:34 | Re: [PATCH] psql: tab completion for ALTER ROLE ... IN DATABASE ... |
| Previous Message | zengman | 2026-01-06 13:34:15 | Re: [PATCH] psql: tab completion for ALTER ROLE ... IN DATABASE ... |