| From: | Raja Sai pranav <rajasaipranav0(at)gmail(dot)com> |
|---|---|
| To: | masao(dot)fujii(at)gmail(dot)com |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org, imchifan8(at)gmail(dot)com |
| Subject: | Re: BUG #19881: CLUSTER uses a disabled sort path when enable_sort is off |
| Date: | 2026-11-21 07:05:57 |
| Message-ID: | nh-3b9619a3-ca8e-4e6f-b78b-6dcec89a9d7d@google.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Sat, Nov 21, 2026 at 3:54 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> It's helpful if you provide the patches for old stable versions.
Attached is a version for REL_18_STABLE. It has only the
compare_path_costs() part, since 18 has no default_pgs_mask, and the test
checks only enable_sort. I ran it on REL_18_STABLE: the regression tests
pass, and without the code change the new test fails ("using sequential
scan and sort" instead of "using index scan").
REL_17_STABLE and older don't need it. They still add disable_cost to a
disabled sort, so comparing total_cost already avoids it there. v2 applies
to REL_19_STABLE as is.
> BTW, regarding the discussion on the list, could you avoid top-posting?
> Bottom-posting is the preferred style on this mailing list.
Sorry about that, I'll bottom-post from now on.
Regards,
Sai Pranav
| Attachment | Content-Type | Size |
|---|---|---|
| REL_18-v2-0001-Honor-enable_sort-in-CLUSTER-s-choice-of-plan.patch | text/x-patch | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Raja Sai pranav | 2026-11-21 07:11:49 | Re: BUG #19895: dblink() never returns and spins at 100% CPU when the remote command is COPY ... TO STDOUT; |
| Previous Message | Ishjaap Singh | 2026-11-21 07:02:15 | Re: BUG #19925: ECPG inserts host variables unquoted in EXECUTE name(...) |