Re: Extensions, this time with a patch

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions, this time with a patch
Date: 2010-10-20 07:10:27
Message-ID: m2sk01jq58.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> It seems good to do this in the normal case, but (1) if
>> client_min_messages was already set higher than WARNING, we probably
>> should not lower it and (2) we might want to have a way to lower it
>> for troubleshooting purposes.
>
> I think the standard way of troubleshooting would be to run the
> extension's script by hand, no? So while I agree with (1),
> I'm not sure we need to sweat about (2).

Will go and fix (1), but like Tom I think (2) is handled by the
extension's author running pg_execute_from_file() rather than CREATE
EXTENSION for debugging purposes: then the settings are not changed.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen R. van den Berg 2010-10-20 07:13:45 Re: pg_rawdump
Previous Message Terry Laurenzo 2010-10-20 06:58:34 Re: patch: Add JSON datatype to PostgreSQL (GSoC, WIP)