| From: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Joshua Tolley <eggyknap(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_execute_from_file review |
| Date: | 2010-12-06 10:20:36 |
| Message-ID: | m2sjybtd6z.fsf@2ndQuadrant.fr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Why is there a variadic replace() in this patch at all? It seems just
> about entirely unrelated to the stated purpose of the patch, as well
> as being of dubious usefulness.
It used not to being exposed at the SQL level, but just an internal loop
in pg_execute_sql_file() when using the placeholders enabled
variant. Then Itagaki wanted me to expose internals so that he basically
can implement the logics in SQL directly. It seems like we went a step
too far in exposing this facility too. Agreed in removing it at the SQL
level.
I assume you want me to prepare a patch, I'm not sure about being able
to send it to the list before Thursday --- unless I get around the git
network errors at pgday.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hitoshi Harada | 2010-12-06 10:48:38 | Re: SQL/MED - file_fdw |
| Previous Message | Fujii Masao | 2010-12-06 08:13:10 | wal_sender_delay is still required? |