| From: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ALTER OBJECT any_name SET SCHEMA name |
| Date: | 2010-11-04 14:52:53 |
| Message-ID: | m2mxppm98a.fsf@2ndQuadrant.fr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> 1. wouldn't it make more sense to save the extension namespace in the
> extension catalog?
I don't think so, because the extension itself is not schema
qualified. What lives in the namespace the extension depends on is not
the extension itself, but its objects.
> 2. I think the guts of AlterExtensionNamespace (the large switch block)
> should be elsewhere, probably in alter.c
Makes sense, will move there.
> 3. Not this patch, but I think using "extension" as a global variable
> name is a bad idea.
What about create_extension_extension instead? I'm not thinking of
something better, bikeshedding is opened.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-11-04 15:05:24 | Re: ALTER OBJECT any_name SET SCHEMA name |
| Previous Message | Tom Lane | 2010-11-04 14:51:08 | Re: ALTER OBJECT any_name SET SCHEMA name |