Re: max_standby_delay considered harmful

From: Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Greg Smith <greg(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>
Subject: Re: max_standby_delay considered harmful
Date: 2010-05-09 11:59:50
Message-ID: m2k4rdwaix.fsf@hi-media.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> I like the proposal of a boolean because it provides only the minimal
> feature set of two cases that are both clearly needed and easily
> implementable. Whatever we do later is certain to provide a superset
> of those two cases. If we do something else (and that includes my own
> proposal of a straight lock timeout), we'll be implementing something
> we might wish to take back later. Taking out features after they've
> been in a release is very hard, even if we realize they're badly
> designed.

That's where I though my proposal fitted in. I fail to see us wanting to
take back explicit pause/resume admin functions in any future release.

Now, after having read Greg's arguments, my vote would be the following:
- hot_standby_conflict_winner = queries|replay, defaults to replay
- add pause/resume so that people can switch temporarily to queries
- label max_standby_delay *experimental*, keep current code

By clearly stating the feature is *experimental* it should be easy to
both get feedback on it so that we know what to implement in 9.1, and
should that be completely different, take back the feature. It should
even be possible to continue tweaking its behavior during beta, or do
something better.

Of course it will piss off some users, but they knew they were depending
on some *experimental* feature after all.

Regards,
--
dim

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Florian Pflug 2010-05-09 14:10:34 Re: max_standby_delay considered harmful
Previous Message Kevin Grittner 2010-05-09 11:40:27 Re: max_standby_delay considered harmful