| From: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PostgreSQL-Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Extensions, patch v19 (encoding brainfart fix) (was: Extensions, patch v18 (merge against master, bitrot-only-fixes)) |
| Date: | 2010-12-16 17:00:04 |
| Message-ID: | m2k4j9psa3.fsf_-_@2ndQuadrant.fr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> I would think that we want to establish the same policy as we have for
> dictionary files: they're assumed to be UTF-8. I don't believe there
> should be an encoding option at all. If we didn't need one for
> dictionary files, there is *surely* no reason why we have to have one
> for extension SQL files.
Brain-fart from me in the v18, that I've produced while being pressed by
other distractions. Fixed now in the attached, v19. Sorry about that, I
was too eager to produce the no-moving-parts "final" patch. Time to find
this quote about parallelism and time lost I guess.
So, attached patch fixes the v18 regression wrt to script file encoding
and establish UTF-8 as the default encoding to consider to read a script
file. Thanks for your comments.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
| Attachment | Content-Type | Size |
|---|---|---|
| extension.v19.patch.gz | application/octet-stream | 118.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-12-16 17:12:30 | Re: [PATCH] V3: Idle in transaction cancellation |
| Previous Message | Tom Lane | 2010-12-16 16:58:24 | Re: [PATCH] V3: Idle in transaction cancellation |