Re: [HACKERS] Platforms with v6.3 trouble

From: "Billy G(dot) Allie" <Bill(dot)Allie(at)mug(dot)org>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: lockhart(at)alumni(dot)caltech(dot)edu, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Platforms with v6.3 trouble
Date: 1998-02-27 05:52:53
Message-ID: m0y8Ij8-0009hRC@bgalli.mug.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> This is fine, and a good place to put it, though the port-specific
> change should go AFTER the standard #define, not before it, so you do:
>
> #if !defined(SCO)
> #define
> #else
> static ...
> #endif

I'll make this change before submitting the patch.

> [...] The new macro formatting style is my
> idea too, and it makes things much simpler. Look at the ugly
> heap_getattr() macros in 6.2.

Agreed, and I have.
--
____ | Billy G. Allie | Domain....: Bill(dot)Allie(at)mug(dot)org
| /| | 7436 Hartwell | Compuserve: 76337,2061
|-/-|----- | Dearborn, MI 48126| MSN.......: B_G_Allie(at)email(dot)msn(dot)com
|/ |LLIE | (313) 582-1540 |

Browse pgsql-hackers by date

  From Date Subject
Next Message Brett McCormick 1998-02-27 06:18:11 money_words_out segfaults
Previous Message Vadim B. Mikheev 1998-02-27 05:15:21 Re: [HACKERS] INT2OID, etc.