Re: make -C src/test/isolation failure in index-killtuples due to btree_gist

Hi,

On 2025-08-18 08:57:13 +0900, Michael Paquier wrote:
> The following command fails, because btree_gist is not installed in
> the context of the isolation tests:
> make -C src/test/isolation/
>
> This test has been added recently by 377b7ab14524. Some efforts have
> been done lately to remove any dependency to contrib/ in
> src/test/regress/, like b1720fe63f34

I don't see what the point of that effort is. All it's doing is to make it
ever harder to write tests. IMO we should go diametrically the opposite way
and assume that we have fully built postgres when running tests.

> and it does not strike me as a good idea to begin doing that in the main
> isolation test suite, so perhaps the best thing to do here is just move this
> test to contrib/btree_gist/?

No, it makes absolutely no sense to test e.g. hash killtuples support in
btree_gist.

> and there's the matter of the test correctness.

What are you trying to say here?

Greetings,

Andres Freund