Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

On Wed, Apr 28, 2010 at 4:43 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> Ok, did that. Here's an updated patch:

> + During recovery, specifies whether or not you can connect and run
> + queries to enable <xref linkend="hot-standby">. The default value is
> + <literal>on</literal>.
> + This parameter can only be set at server start. It is ignored when
> + not in standby mode.

In the patch, I was not able to find any change which ignores
recovery_connections when standby_mode is OFF.

And that change spoils the combination of pg_standby and HS?
We drop the support for it?

> * renamed wal_mode to wal_level

We should replace "mode" with "level" in the document of wal_level
parameter as follows?

@@ -1368,9 +1368,9 @@ SET ENABLE_SEQSCAN TO OFF;
read-only queries on a standby server.
This parameter can only be set at server start.
</para>
<para>
- In <literal>minimal</> mode, WAL-logging of some bulk operations, like
+ In <literal>minimal</> level, WAL-logging of some bulk operations, like
<command>CREATE INDEX</>, <command>CLUSTER</> and <command>COPY</> on
a table that was created or truncated in the same transaction can be
safely skipped, which can make those operations much faster (see
<xref linkend="populate-pitr">). But minimal WAL does not contain
@@ -1379,15 +1379,15 @@ SET ENABLE_SEQSCAN TO OFF;
WAL archiving (<xref linkend="guc-archive-mode">) and streaming
replication.
</para>
<para>
- In <literal>hot_standby</> mode, the same information is logged as
- in <literal>archive</> mode, plus information needed to reconstruct
+ In <literal>hot_standby</> level, the same information is logged as
+ in <literal>archive</> level, plus information needed to reconstruct
the status of running transactions from the WAL. To enable read-only
queries on a standby server, <varname>wal_level</> must be set to
<literal>hot_standby</> on the primary. It is thought that there is
little measurable difference in performance from using
- <literal>hot_standby</> mode over <literal>archive</>, so feedback
+ <literal>hot_standby</> level over <literal>archive</>, so feedback
is welcome if any production impacts are noticeable.
</para>
</listitem>
</varlistentry>

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center