| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: queryId constant squashing does not support prepared statements |
| Date: | 2025-05-13 16:57:35 |
| Message-ID: | kxz3mo5tvxzlc7w6ptkflqgsrhqj3bydisbqazyuven5r2hotm@ugq2yadkjix3 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mon, May 12, 2025 at 06:40:43PM GMT, Sami Imseih wrote:
> > The static variables was only part of the concern, another part was
> > using A_Expr to carry this information, which will have impact on lots
> > of unrelated code.
>
> What would be the problem if A_Expr carries an extra pointer to a List?
> It already had other fields, rexpr, lexpr and location that could be no-op.
They can be empty sometimes, but the new fields will be empty 99% of the
time. This is a clear sign to me that this informaton does not belong to
a node for "infix, prefix, and postfix expressions", don't you think?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2025-05-13 18:07:10 | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |
| Previous Message | Yura Sokolov | 2025-05-13 16:22:29 | ARM/ARM64 SpinLockAcquire and SpinLockRelease are not full barriers |