Re: [PATCH v12] GSSAPI encryption support

From: Robbie Harwood <rharwood(at)redhat(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH v12] GSSAPI encryption support
Date: 2016-04-05 00:06:06
Message-ID: jlgy48ssyvl.fsf@thriss.redhat.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hello friends,

Here's v12, both here and on my github:
https://github.com/frozencemetery/postgres/tree/feature/gssencrypt12

What changed:

- The code is aware of memory contexts now. I actually really like the
memory context stuff; just didn't see any indication of its existence
in the code I had read. Anyway, we allocate server buffers in the
connection-lifetime context. The other alternative that we discussed
on IRC a bit was to avoid palloc()/pfree() entirely in favor of raw
calloc()/free(), but I think if possible I prefer this approach since
I find the StringInfo handy to work with. This eliminates the
traceback for me with --enable-cassert.

- Error cleanup. I've been looking very hard at this code in order to
try to fix the assert, and I've fixed up a couple error paths that
hadn't been taken. This involves replacing the double-send with a
buffer-and-then-send, which turns out to be not only shorter but
easier for me to reason about.

Thanks!

Attachment Content-Type Size
v12-0001-Move-common-GSSAPI-code-into-its-own-files.patch text/x-diff 15.1 KB
v12-0002-Connection-encryption-support-for-GSSAPI.patch text/x-diff 46.3 KB
v12-0003-GSSAPI-authentication-cleanup.patch text/x-diff 6.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-04-05 00:11:17 Re: show xl_prev in xlog.c errcontext
Previous Message Robert Haas 2016-04-04 23:59:54 oversight in parallel aggregate