| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Subject: | oversight in parallel aggregate |
| Date: | 2016-04-04 23:59:54 |
| Message-ID: | CA+TgmoY41dpHOEXkGStvHj0dAh4cRvy_XjXFEdGsPoCSfy+EtA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
One of my EDB colleagues, while in the process of refactoring some
unrelated Advanced Server code, discovered that (1) there's no way to
mark an aggregate as anything other than parallel-unsafe but (2) it
doesn't matter because has_parallel_hazard ignores Aggrefs anyway.
These mistakes cancel each other out (sorta) if all of your aggregates
happen to be parallel-safe, but otherwise not so much. Barring
objections, I intend to speedily apply the attached patch to fix this.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| create-aggregate-parallel.patch | binary/octet-stream | 7.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robbie Harwood | 2016-04-05 00:06:06 | Re: [PATCH v12] GSSAPI encryption support |
| Previous Message | Peter Geoghegan | 2016-04-04 22:48:45 | Re: WIP: Covering + unique indexes. |