Re: [PATCH v11] GSSAPI encryption support

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:

> On Sat, Apr 2, 2016 at 7:34 AM, Robbie Harwood <rharwood(at)redhat(dot)com> wrote:
>
>> Since I still can't reproduce this locally (left a client machine and
>> a process on the same machine retrying for over an hour on your test
>> case and didn't see it), could you provide me with some more
>> information on why repalloc is complaining?
>> Is this a low memory situation where alloc might have failed?
>
> No, this is an assertion failure, and it seems that you are compiling
> this code without --enable-cassert, without the switch the code
> actually works.

You are right. I now see the assertion failure.

>> That pointer looks like it's on the heap, is that correct?
>
> appendBinaryStringInfo depends on palloc calls that allocate memory
> depending on the memory context used. It looks that what's just
> missing in your logic is a private memory context that be_gssapi_write
> and be_gssapi_read can use to handle the allocation of the
> communication buffers.

Thank you very much for the pointer! I will work in memory context
management for the next version.