Skip site navigation (1) Skip section navigation (2)

Re: BUG #5394: invalid declspec for PG_MODULE_MAGIC

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Vladimir Barzionov <snego(dot)barsik(at)gmail(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #5394: invalid declspec for PG_MODULE_MAGIC
Date: 2010-04-07 10:27:13
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-bugspgsql-hackers
On Tue, Apr 6, 2010 at 21:55, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Mon, Mar 29, 2010 at 11:47 AM, Takahiro Itagaki
>> <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>>> A patch attached. The name of "PGMODULEEXPORT" might be arguable.
>> I agree with this in principle, but won't this break every single
>> add-on module out there that supports Win32?
> The patch didn't touch the contrib modules, so why would it break
> third-party sources?

Oh, d'oh. I was clearly too tired when reading that thing. I was
thinking we required changes in the contrib modules/third party
modules, but they don't actually use DLLEXPORT, do they?

In that case, that argument clearly falls, and I'm in favour of the
patch :-) Just make sure you test it on both current and semi-old
versions of mingw, they tend to not always act the same way. Or just
get it in and the buildfarm can figure that part out for us.

 Magnus Hagander

In response to

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2010-04-07 10:31:22
Subject: Re: Win32 timezone matching
Previous:From: Heikki LinnakangasDate: 2010-04-07 10:23:24
Subject: Re: [COMMITTERS] pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()

pgsql-bugs by date

Next:From: Gaetan beaulieuDate: 2010-04-07 12:49:27
Subject: CTRL-Z in the SQL command editor.
Previous:From: karolyDate: 2010-04-07 09:56:06
Subject: BUG #5405: Consol and utf8

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group