| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | {heap,minimal}_expand_tuple() are unused |
| Date: | 2026-08-07 19:14:11 |
| Message-ID: | gf6hokynqjp6g7o4zh6yy7ekbdbig5cnnd6ilk6iw3aodilj43@5x7xrz52jhve |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
As of
commit 20d3fe9009d
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Date: 2020-10-26 11:36:53 -0400
In INSERT/UPDATE, use the table's real tuple descriptor as target.
heap_expand_tuple() is unused. The use before that commit was short-lived
(ba9f18abd). Before that it was unused, since
commit 171e0418b03
Author: Andres Freund <andres(at)anarazel(dot)de>
Date: 2019-02-06 01:09:32 -0800
Fix heap_getattr() handling of fast defaults.
As of
commit 4da597edf1b
Author: Andres Freund <andres(at)anarazel(dot)de>
Date: 2018-11-16 16:35:11 -0800
Make TupleTableSlots extensible, finish split of existing slot type.
minimal_expand_tuple() is unused.
Both heap_expand_tuple() and minimal_expand_tuple() being unused, make
expand_tuple() unused in turn.
I think we probably ought to remove all three in 20? I didn't find external
callers. It's nontrivial enough code that I don't think we should keep it
around just because somebody might be using it.
Thoughts?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexandre Felipe | 2026-08-07 19:23:33 | Re: COALESCE patch |
| Previous Message | Tom Lane | 2026-08-07 17:15:29 | Draft back-branch release notes are up |