| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Subject: | Re: Heads Up: cirrus-ci is shutting down June 1st |
| Date: | 2026-06-04 02:46:14 |
| Message-ID: | fovrlyxqimnvl55iiopsaauwrjipws3dmbcxpyutc4v5irat3y@rn5gnt47hebj |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2026-06-03 19:36:29 -0400, Andres Freund wrote:
> > Concretely: I propose that we bail out of the setup step if the
> > repository isn't postgres/postgres, just for the initial committed
> > version, and then we can test what this actually does in practice to
> > our downstream forks. If I'm being overly paranoid, we can immediately
> > remove it; else we can add an opt-in. But adding it after the fact
> > won't protect anyone who synced up in the interim.
>
> We clearly would need to have an opt-out from that from the get-go, otherwise
> I couldn't even test that things are still working before merging, and
> postgresql-cfbot won't work... Thomas has it otherwise mostly ready to go
> (this thread actually is being tested automatically already).
Attached is a possible implementation of this. If the PG_CI_ENABLED
repository variable is not set to 1, we run as little CI as possible.
To make that less confusing, emit a summary whenever we skip running CI, with
a message explaining how to enable CI. See e.g. the bottom of
https://github.com/anarazel/postgres/actions/runs/26926523027
Unfortunately this summary is only visible when logged into github.
Attached is a squashed version of my earlier changes. In addition:
- src/tools/ci/README was updated with the knowledge that the workflow
may or may not be enabled in a fork
- a few typos etc were fixed
- the change above was added as a third patch
I'm on the fence whether we want the third change or not.
I'd like to push the CI support tomorrow morning. Perhaps othes will chime
about whether we should require this explicit opt-in or not...
Greetings,
Andres Freund
| Attachment | Content-Type | Size |
|---|---|---|
| v10a-0001-ci-Add-GitHub-Actions-based-CI.patch | text/x-diff | 49.9 KB |
| v10a-0002-ci-Remove-support-for-cirrus-ci-based-CI.patch | text/x-diff | 43.8 KB |
| v10a-0003-ci-Make-CI-workflow-as-opt-in-as-possible.patch | text/x-diff | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | cca5507 | 2026-06-04 02:43:47 | Re: Use streaming read I/O when enabling data checksums online |