Re: perlcritic script

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: perlcritic script
Date: 2018-05-08 21:03:36
Message-ID: fff73c19-c36e-3173-d7b5-a9a4f579be5c@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/8/18 16:51, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> On 5/8/18 13:57, Andrew Dunstan wrote:
>>> + # take executable files that file(1) thinks are perl files
>>> + find . -type f -perm -100 -exec file {} \; -print |
>>> + egrep -i ':.*perl[0-9]*\>' |
>
>> How portable is that?
>
> Well, it's the same code that's in pgperltidy ... but I agree that
> it's making a lot of assumptions about the behavior of file(1).

OK, but then it's not a problem for this thread.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-05-08 21:05:59 Re: [HACKERS] Parallel Append implementation
Previous Message Tom Lane 2018-05-08 20:51:48 Re: perlcritic script