| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Avoid generating SSL certs for LDAP tests |
| Date: | 2022-12-19 16:04:53 |
| Message-ID: | ff407f18-ffa7-9dd8-bf5a-413bce775859@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-12-19 Mo 10:25, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> We don't generate SSL certificates for running the SSL tests, but
>> instead use pregenerated certificates that are part of our source code.
>> This patch applies the same policy to the LDAP tests, and in fact simply
>> reuses certificates from the SSL test suite by copying them. It won't
>> save much but it should save a handful of cycles at run time.
> +1, but should there be a comment somewhere under test/ssl pointing
> out this external use of the certs?
OK, I'll find a place to mention that.
> Also, I bet this needs some adjustment for VPATH builds.
I have tested it with both a make style vpath build and with meson - it
works fine.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-12-19 16:16:08 | Add a test to ldapbindpasswd |
| Previous Message | Nikita Malakhov | 2022-12-19 15:51:39 | Re: Patch: Global Unique Index |