Re: Another small pl/perl patch

From: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: Another small pl/perl patch
Date: 2005-10-24 15:06:48
Message-ID: fdfc8957c5dc4b263c8bd48c2f6fa903@biglumber.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> Well, I personally almost always use indirect file handles rather than
> globals. But I don't know that using globals file handles (which is what
> I gather you are objecting to) is deprecated, is it? The perl docs are
> absolutely littered with examples.

No, my primary objection was using open() without checking the result.
Everything else was icing. :)

> (I also use BSD style intentation consistently across my C, perl and
> Java ... which is unusual at least in the latter 2 cases but works well
> for me ;-) )

I tried to match the indenting to what is already in the docs, which is
fairly close to my own style.

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
PGP Key: 0x14964AC8 200510241105
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8

-----BEGIN PGP SIGNATURE-----

iD8DBQFDXPhjvJuQZxSWSsgRAm6RAKD0RmrD5U5Uzv73wBVIfiCAIpAWewCg6XzJ
cPfuNaMX/gD+vA1VugR2YYo=
=va+e
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2005-10-24 15:22:00 Re: Another small pl/perl patch
Previous Message Andrew Dunstan 2005-10-24 13:51:39 Re: Another small pl/perl patch