From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Jelte Fennema <postgres(at)jeltef(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Subject: | Re: run pgindent on a regular basis / scripted manner |
Date: | 2023-06-20 13:21:14 |
Message-ID: | fdc638a0-60a0-ac64-e265-9dd6ea15a90e@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2023-06-20 Tu 09:08, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> On 2023-06-19 Mo 17:07, Tom Lane wrote:
>>> Is koel tracking the right repo? It just spit up with a bunch of
>>> diffs that seem to have little to do with the commit it's claiming
>>> caused them:
>> Yeah, I changed it so that instead of just checking new commits it would
>> check the whole tree. The problem with the incremental approach is that
>> the next run it might turn green again but the issue would not have been
>> fixed.
> Ah.
>
>> I think this is a one-off issue. Once we clean up the tree the problem
>> would disappear and the commits it shows would be correct. I imaging
>> that's going to happen any day now?
> I can go fix the problems now that we know there are some (already).
> However, if what you're saying is that koel only checks recently-changed
> files, that's going to be pretty misleading in future too. If people
> don't react to such reports right away, they'll disappear, no?
>
>
That's what would have happened if I hadn't changed the way it worked
(and that's why I changed it). Now it doesn't just check recent commits,
it checks the whole tree, and will stay red until the tree is fixed.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | torikoshia | 2023-06-20 13:27:36 | Re: Allow pg_archivecleanup to remove backup history files |
Previous Message | Tom Lane | 2023-06-20 13:08:36 | Re: run pgindent on a regular basis / scripted manner |