| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Addition of PostgreSQL::Test::Cluster::pg_version() |
| Date: | 2022-05-19 11:28:53 |
| Message-ID: | fdb49907-1c4b-f32a-c2ad-c178b7512966@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-05-18 We 21:38, Michael Paquier wrote:
> Hi all,
> (Added Andrew in CC.)
>
> While working more on expanding the tests of pg_upgrade for
> cross-version checks, I have noticed that we don't expose a routine
> able to get back _pg_version from a node, which should remain a
> private field of Cluster.pm. We already do that for install_path, as
> of case added by 87076c4.
>
> Any objections or comments about the addition of a routine to get the
> PostgreSQL::Version, as of the attached?
>
Looks ok. PostgreSQL::Version is designed so that the object behaves
sanely in comparisons and when interpolated into a string.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ronan Dunklau | 2022-05-19 11:47:36 | Re: Removing unneeded self joins |
| Previous Message | Amit Kapila | 2022-05-19 11:12:31 | Re: Build-farm - intermittent error in 031_column_list.pl |