Re: Yet another fast GiST build

On 13/01/2021 12:34, Heikki Linnakangas wrote:
> On 13/01/2021 11:46, Andrey Borodin wrote:
>>> 13 янв. 2021 г., в 13:41, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
>>> написал(а):
>>>
>>>> One more question: will bytea tests run correctly on
>>>> 32bit\different-endian systems?
>>>
>>> Good question. Somehow I thought we were printing esseantilly text
>>> values as bytea. But they are Points, which consists of float8's.
>>> Since I already pushed this, I'm going to just wait and see what
>>> the buildfarm says, and fix if needed. I think the fix is going to
>>> be to just remove the test for the bytea-variant, it doesn't seem
>>> that important to test.
>>
>> Maybe we can just omit key_data from tests?
>
> Make sense, fixed it that way. Thanks!

Buildfarm animal thorntail is still not happy:

> --- /home/nm/farm/sparc64_deb10_gcc_64_ubsan/HEAD/pgsql.build/../pgsql/contrib/pageinspect/expected/gist.out 2021-01-13 13:38:09.721752365 +0300
> +++ /home/nm/farm/sparc64_deb10_gcc_64_ubsan/HEAD/pgsql.build/contrib/pageinspect/results/gist.out 2021-01-13 14:12:21.540046507 +0300
> @@ -3,21 +3,21 @@
> CREATE INDEX test_gist_idx ON test_gist USING gist (p);
> -- Page 0 is the root, the rest are leaf pages
> SELECT * FROM gist_page_opaque_info(get_raw_page('test_gist_idx', 0));
> - lsn | nsn | rightlink | flags
> ------+-----+------------+-------
> - 0/1 | 0/0 | 4294967295 | {}
> + lsn | nsn | rightlink | flags
> +------------+-----+------------+-------
> + 0/1B8357F8 | 0/0 | 4294967295 | {}
> (1 row)

Looks like the LSN on the page is not set to GistBuildLSN as expected.
Weird.

Thorntail is a sparc64 system, so little-endian, but the other
little-endian buildfarm members are not reporting this error. Any idea
what might be going on?

- Heikki