Skip .DS_Store files in check_mode_recursive

From: Andrei Lepikhov <lepihov(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: dgustafsson(at)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Skip .DS_Store files in check_mode_recursive
Date: 2026-07-28 08:53:43
Message-ID: fd55caa3-0a29-4724-afcb-2e7fd4231514@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I am repeatedly encountering an annoying failing test during 'make check-world'
execution on the macOS platform: pg_resetwal with the result:

Failed test 'check PGDATA permissions'

It happens because a filesystem object .DS_Store exists in the directory.
AFAIK, MacOS manages it on its own. Given that I almost never touch this module,
it seems the OS handles it automatically.

A quick dive into the mailing list history shows that this problem has been
discovered [1] and partly fixed [2] before.

It looks like this approach might be extended to TAP tests too. In the
attachment, see the sketch of the code and a minor test to prove that it works.

[1] pg_basebackup: errors on macOS on directories with ".DS_Store" files
https://www.postgresql.org/message-id/flat/E258CE50-AB0E-455D-8AAD-BB4FE8F882FB%40gmail.com
[2] Commit d3fdfdcd1c7 'Skip .DS_Store files in server side utils'

--
regards, Andrei Lepikhov,
pgEdge

Attachment Content-Type Size
v0-0001-Skip-.DS_Store-files-in-check_mode_recursive.patch text/plain 3.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-07-28 08:54:25 Re: tablecmds: fix bug where index rebuild loses replica identity on partitions
Previous Message shveta malik 2026-07-28 08:48:17 Re: Support EXCEPT for TABLES IN SCHEMA publications