Re: Custom oauth validator options

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, VASUKI M <vasukianand0119(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, david(dot)g(dot)johnston(at)gmail(dot)com, Robert Haas <robertmhaas(at)gmail(dot)com>, myon(at)debian(dot)org
Subject: Re: Custom oauth validator options
Date: 2026-01-29 11:58:52
Message-ID: fd412b8e-fab5-43fe-b18d-3e035e4998a7@nataraj.su
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 28.01.2026 22:21, Zsolt Parragi wrote:
>> but I wonder if this is something we
>> should attempt in the context of the larger refactoring done by the
>> patch series here,
> That patch series is interesting but it is about SQL (table, index,
> operator) options, while this is about guc variable validation and
> extension. These seem unrelated to me.

This patch suggests context independent API for managing extension
defined sets of options. It is used for
relation options and similar options, but cat be also used for any
options sets, may be with small modifications.

GUC options are almost same options as relation options. That is why, I
guess, Alvaro suggested you to look at this patch.

And I agree with him. Please have a look at
src/backend/access/common/options.c in that patch. I almost sure this
code can be reused for GUC options too.

Whole https://commitfest.postgresql.org/patch/4688/ is a bit outdated,
and need rebase, but options.c from it is as good as it was before.

And we've just recently committed a small fix that have been blocking
4688's patch rebase. I have plans to rebase it in not so distant future.

It you find it useful for your tasks and even would like to join to
review (at least for options.c part) I would do it with higher priority.
(but it is still my weekend-days project, so it can't be extremely fast)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message VASUKI M 2026-01-29 12:19:47 Re: Optional skipping of unchanged relations during ANALYZE?
Previous Message Japin Li 2026-01-29 11:44:33 Re: Pasword expiration warning