Re: pg_dump bug for extension owned tables

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: fabriziomello(at)gmail(dot)com
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_dump bug for extension owned tables
Date: 2020-07-13 20:05:20
Message-ID: fc54642e-7bba-8dcc-dcd8-7228f8d6ee76@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 7/13/20 2:46 PM, Fabrízio de Royes Mello wrote:
>
>
> >
> > yeah, that's the fix I came up with too. The only thing I added was
> > "Assert(tbinfo->attgenerated);" at about line 2097.
> >
>
> Cool.
>
> >
> > Will wait for your TAP tests.
> >
>
> Actually I've sent it already but it seems to have gone to the
> moderation queue.
>
> Anyway attached with your assertion and TAP tests.
>
>

Thanks, that all seems fine. The TAP test changes are a bit of a pain in
the neck before release 11, so I think I'll just do those back that far,
but the main fix for all live branches.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2020-07-13 20:12:35 Re: Default setting for enable_hashagg_disk
Previous Message David G. Johnston 2020-07-13 19:57:27 Re: Default setting for enable_hashagg_disk