| From: | Jacob Champion <pchampion(at)vmware(dot)com> |
|---|---|
| To: | "magnus(at)hagander(dot)net" <magnus(at)hagander(dot)net> |
| Cc: | "stark(at)mit(dot)edu" <stark(at)mit(dot)edu>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Proposal: Save user's original authenticated identity for logging |
| Date: | 2021-03-09 18:03:03 |
| Message-ID: | fc536fc557a664ad7b9dc0bf46ea335039044905.camel@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2021-03-08 at 22:16 +0000, Jacob Champion wrote:
> On Sat, 2021-03-06 at 18:33 +0100, Magnus Hagander wrote:
> > As for log escaping, we report port->user_name already unescaped --
> > surely this shouldn't be a worse case than that?
>
> Ah, that's a fair point. I'll remove the TODO.
v4 removes the TODO and the extra allocation for peer_user. I'll hold
off on the other two suggestions pending that conversation.
--Jacob
| Attachment | Content-Type | Size |
|---|---|---|
| since-v3.diff.txt | text/plain | 1.1 KB |
| v4-0001-test-kerberos-only-search-forward-in-logs.patch | text/x-patch | 2.5 KB |
| v4-0002-ssl-store-client-s-DN-in-port-peer_dn.patch | text/x-patch | 3.2 KB |
| v4-0003-Log-authenticated-identity-from-all-auth-backends.patch | text/x-patch | 28.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-09 18:04:05 | Re: default result formats setting |
| Previous Message | Joel Jacobson | 2021-03-09 17:48:58 | Re: [PATCH] pg_permissions |