Re: fix more casting away of qualifiers

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Rui Zhao <zhaorui126(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fix more casting away of qualifiers
Date: 2026-10-19 07:09:38
Message-ID: fbf3e2af-6aed-4e9c-aaa9-c601bf06fbb9@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09.10.26 19:32, Rui Zhao wrote:
> Hi Peter,
>
> Thanks very much for continuing this cleanup. V3 0001 looks good to me.
>
> In 0002, could the inner loop in ProcSignalShmemInit() use j instead
> of i? It shadows the outer loop's i, and my GCC 10.2 build reports
> "declaration of 'i' shadows a previous local" with the default
> -Wshadow=local option. I suggest:

Committed with that fix, thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-10-19 07:10:52 Re: Publication of same parent table with ONLY-ness mismatch should error
Previous Message jian he 2026-10-19 07:06:59 Re: [PG19] Three bugs with a CHECK constraint that only the child enforces