| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: SSL tests failing for channel_binding with OpenSSL <= 1.0.1 |
| Date: | 2019-09-30 18:08:20 |
| Message-ID: | fb96724b8aa5f56a14564c51ee8e575538a81aa4.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2019-09-30 at 09:37 -0400, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > On Fri, Sep 27, 2019 at 11:44:57AM +0900, Michael Paquier wrote:
> > > We need to do something similar to c3d41cc for the test, as per
> > > the
> > > attached. I have tested that with OpenSSL 1.0.1 and 1.0.2 to
> > > stress
> > > both scenarios.
> > > Any objections to this fix?
> > Committed as a12c75a1.
>
> The committed fix looks odd: isn't the number of executed tests the
> same in both code paths? (I didn't try it yet.)
test_connect_fails actually runs two tests, one for the failing exit
code and one for the error message.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-09-30 18:08:46 | Re: Minimal logical decoding on standbys |
| Previous Message | Alexander Korotkov | 2019-09-30 17:59:49 | Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock(PG10.7) |