Re: [HACKERS] Subscription code improvements

From: David Steele <david(at)pgmasters(dot)net>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Subscription code improvements
Date: 2018-03-07 14:25:37
Message-ID: fadc0de4-b2bf-519e-e13d-37e51f56eee9@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/7/18 7:41 AM, Masahiko Sawada wrote:
> On Tue, Mar 6, 2018 at 11:17 PM, David Steele <david(at)pgmasters(dot)net> wrote:
>> Hi Masahiko,
>>
>> On 1/30/18 5:00 AM, Masahiko Sawada wrote:
>>> On Fri, Jan 26, 2018 at 11:41 AM, Peter Eisentraut
>>> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>>>> On 1/24/18 02:33, Masahiko Sawada wrote:
>>>>> Thank you for notification. Since it seems to me that no one is
>>>>> interested in this patch, it would be better to close out this patch.
>>>>> This patch is a refactoring patch but subscription code seems to work
>>>>> fine so far. If a problem appears around subscriptions, I might
>>>>> propose it again.
>>
>> This patch is still in the Waiting for Author state but it looks like
>> you intended to close it. Should I do so now?
>
> Uh, actually three(0001 - 0002) of four patches applies cleanly to
> current HEAD, and I think we can regards them as "Needs Review". Only
> 0003 and 0004 patch are under "Waiting on Author". Since 0001 and 0002
> are very simple I hope these patch get reviewed. It was a my fault to
> get different patches into one CF entry.
I rather doubt you are going to attract any review as long is this stays
in Waiting on Author state -- which I notice it has been in since the
end of the November CF. That is reason enough to return it since we
have been taking a pretty firm stance on patches that have not been
updated for the CF.

I'm marking this submission Returned with Feedback.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Chalke 2018-03-07 14:30:37 Re: [HACKERS] Partition-wise aggregation/grouping
Previous Message Peter Eisentraut 2018-03-07 14:22:16 Re: public schema default ACL