Re: On login trigger: take three

From: a(dot)sokolov(at)postgrespro(dot)ru
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Ivan Panchenko <wao(at)mail(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Subject: Re: On login trigger: take three
Date: 2022-04-01 07:16:04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Daniel Gustafsson писал 2022-03-30 16:48:
>> On 30 Mar 2022, at 13:21, Ivan Panchenko <wao(at)mail(dot)ru> wrote:
>> Maybe side-effects is a bit too general? Emitting a log message,
>> rejecting a
>> login, setting some GUCs, etc are all side-effects too.
>> Something like this:
> I've reworded the docs close to what you suggested here.
>> Also, please fix a typo in doc/src/sgml/ref/create_event_trigger.sgml
>> :
> Done.
>> Regarding the trigger function example:
>> It does not do anything if run on a standby. To show that it can do
>> something on a standby to, I propose to move throwing the night
>> exception to the beginning.
> Good idea, done.
>> Finally, let me propose to append to the regression test the
>> following:
> Also a good idea, done.
> --
> Daniel Gustafsson

Please fix a typo in doc/src/sgml/event-trigger.sgml: "precvent"

Andrey Sokolov
Postgres Professional:

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2022-04-01 07:44:23 Re: Skipping logical replication transactions on subscriber side
Previous Message vignesh C 2022-04-01 07:15:50 Re: Handle infinite recursion in logical replication setup