Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.

From: David Steele <david(at)pgmasters(dot)net>
To: Shinya11(dot)Kato(at)nttdata(dot)com, movead(dot)li(at)highgo(dot)ca
Cc: pgsql-hackers(at)postgresql(dot)org, andres(at)anarazel(dot)de, michael(at)paquier(dot)xyz, ahsan(dot)hadi(at)highgo(dot)ca, horikyota(dot)ntt(at)gmail(dot)com
Subject: Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
Date: 2021-03-18 14:26:03
Message-ID: fa69fe77-a64b-0207-fbd0-3d16b4940c95@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/7/21 2:55 AM, Shinya11(dot)Kato(at)nttdata(dot)com wrote:
>>But 0 value maybe looks strange, so in current version I show it like below:
>>Type N (%) Record size (%) FPI size (%) Combined size (%)
>>---- - --- ----------- --- -------- --- ------------- ---
>>...
>>XLOG/SWITCH_JUNK - ( -) 11006248 ( 72.26) - ( -) 11006248 ( 65.78)
>>Transaction/COMMIT 10 ( 0.03) 340 ( 0.00) 0 ( 0.00) 340 ( 0.00)
>
> I just wanted to know why the "count" and "fpi_len" fields 0 are.
> So, it would be nice to have 0 values. Sorry for confusing you.

Kato, it's not clear to me if you were asking for - to be changed back to 0?

You marked the patch as Ready for Committer so I assume not, but it
would be better to say clearly that you think this patch is ready for a
committer to look at.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-03-18 14:30:46 Re: a verbose option for autovacuum
Previous Message Dilip Kumar 2021-03-18 14:22:05 Re: [HACKERS] Custom compression methods