Re: SQL JSON path enhanced numeric literals

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Vik Fearing <vik(at)postgresfriends(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SQL JSON path enhanced numeric literals
Date: 2023-03-05 15:55:18
Message-ID: fa4aad10-0c36-df32-f800-9a9629dff0bb@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03.03.23 21:16, Dean Rasheed wrote:
> I think this new feature ought to be mentioned in the docs somewhere.
> Perhaps a sentence or two in the note below table 9.49 would suffice,
> since it looks like that's where jsonpath numbers are mentioned for
> the first time.

Done. I actually put it into the data types chapter, where some other
differences between SQL and SQL/JSON syntax were already discussed.

> In jsonpath_scan.l, I think the hex/oct/bininteger cases could do with
> a comment, such as
>
> /* Non-decimal integers in ECMAScript; must not have underscore after radix */
> hexinteger 0[xX]{hexdigit}(_?{hexdigit})*
> octinteger 0[oO]{octdigit}(_?{octdigit})*
> bininteger 0[bB]{bindigit}(_?{bindigit})*
>
> since that's different from the main lexer's syntax.

done

> Perhaps it's worth mentioning that difference in the docs.

done

> Otherwise, this looks good to me.

committed

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joseph Koshakow 2023-03-05 16:39:58 Re: Date-Time dangling unit fix
Previous Message Ankit Kumar Pandey 2023-03-05 15:27:45 Re: How does pg implement the visiblity of one tuple for specified transaction?