Re: Commitfest 2021-11 Patch Triage - Part 1

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Commitfest 2021-11 Patch Triage - Part 1
Date: 2021-12-02 20:01:53
Message-ID: f9a6f56c-8958-3c25-2976-e3262167172d@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/2/21 12:06, Daniel Gustafsson wrote:
>> On 6 Nov 2021, at 17:20, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>>
>> On 11/5/21 22:15, Daniel Gustafsson wrote:
>>> ...
>>> 1651: GROUP BY optimization
>>> ===========================
>>> This is IMO a desired optimization, and after all the heavy lifting by Tomas
>>> the patch seems to be in pretty good shape.
>>
>> I agree it's desirable. To move the patch forward, I need some feedback on the costing questions, mentioned in my last review, and the overall approach to planning (considering multiple group by variants).
>
> I'm moving this to the next CF with the hope that more feedback is received.
> If you think "Ready for Committer" is a more suitable status, please do update
> it as I'm leaving it in Needs Review for now not having the full context.

I don't think anyone reviewed the costing, so I think "needs review" is
appropriate.

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-12-02 20:46:09 Re: pg_dump versus ancient server versions
Previous Message Tomas Vondra 2021-12-02 19:58:44 Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path