Re: Temporary WAL segments files not cleaned up after an instance crash

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Temporary WAL segments files not cleaned up after an instance crash
Date: 2018-07-12 12:40:43
Message-ID: f93fd0a2-6cc2-978f-7a3b-5f34a7d9bc0c@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/07/18 15:38, Michael Paquier wrote:
> On Thu, Jul 12, 2018 at 01:15:03PM +0300, Heikki Linnakangas wrote:
>> On 12/07/18 10:44, Michael Paquier wrote:
>>> + snprintf(path, MAXPGPATH, XLOGDIR "/%s", xlde->d_name);
>>> + elog(DEBUG2, "removed temporary WAL file \"%s\"", path);
>>> + unlink(path);
>>
>> The elog message says "removed", but the removal actually happens after the
>> elog. "removing" would be more accurate.
>
> Or just move the elog() after the file is actually removed? Would you
> be fine with that?

Sure.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2018-07-12 13:01:25 Re: partition pruning doesn't work with IS NULL clause in multikey range partition case
Previous Message Michael Paquier 2018-07-12 12:38:38 Re: Temporary WAL segments files not cleaned up after an instance crash